Update to crossterm-0.25 #3390
Update to crossterm-0.25 #3390
Conversation
| @@ -271,6 +273,11 @@ impl From<crossterm::event::Event> for Event { | |||
| crossterm::event::Event::Key(key) => Self::Key(key.into()), | |||
| crossterm::event::Event::Mouse(mouse) => Self::Mouse(mouse.into()), | |||
| crossterm::event::Event::Resize(w, h) => Self::Resize(w, h), | |||
| crossterm::event::Event::FocusGained => Self::FocusGained, | |||
There was a problem hiding this comment.
Focus events are emitted on Windows regardless of any flags being set in crossterm. Don't want to use unreachable like in the Paste arm as a result.
helix-view/src/input.rs
Outdated
| kind: _, | ||
| state: _, |
There was a problem hiding this comment.
these can be discarded a bit more tersely with
crossterm::event::KeyEvent { code, modifiers, .. }
archseer
force-pushed
the
update-crossterm-0.25
branch
from
52cf6fd
to
19889a5
Compare
|
Resolved the comment and added a note about the extra state now offered by crossterm |
|
I am using Kitty, does this update mean I can now use some variation of |
|
I see |
|
@the-mikedavis i have added: and am running the latest Kitty and the latest Helix. It does not do anything, when I press ctrl-backspace it just deletes a character as it did before. |
|
We might need to enable some of the keyboard enhancement flags to pick up on previously unsupported key combos. I haven't looked into what happens on other terms when emitting those flags, so I didn't want to just enable it here. |
|
@groves Would you be able to add them? It would be much appreciated! |
I've got a couple PRs that depend on this update. I thought it'd be nice to get the library bump in separately to keep from conflating any issues.